feat: implement plugin#1
Merged
chenjiahan merged 7 commits intomainfrom Feb 11, 2025
Merged
Conversation
- Completely rewrote README.md with comprehensive documentation - Updated example project configuration and routes - Improved dev server and plugin configuration handling - Added more detailed styling and interactive elements to documentation pages - Refined plugin options and configuration management - Enhanced server-side rendering and custom server support
|
@ScriptedAlchemy Is there any feedback/buy-in from the remix guys at the moment? |
chenjiahan
reviewed
Feb 6, 2025
| "@types/node": "^22.10.1", | ||
| "@types/react": "^19.0.1", | ||
| "@types/react-dom": "^19.0.1", | ||
| "jiti": "^2.4.1", |
Member
There was a problem hiding this comment.
jiti can be moved to dependencies, otherwise Rslib will bundle it..
chenjiahan
reviewed
Feb 6, 2025
| let clientStats: Rspack.StatsCompilation | undefined; | ||
| api.onAfterEnvironmentCompile(({ stats, environment }) => { | ||
| if (environment.name === 'web') { | ||
| clientStats = stats?.toJson(); |
Member
There was a problem hiding this comment.
Getting all the stats in Rspack is quite slow, if we can specify options it will be faster.
chenjiahan
approved these changes
Feb 11, 2025
Member
|
Let's merge the code into the main branch so more people can see it and contribute 😄 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request primarily focuses on setting up a modern, full-stack React application template using React Router and Cloudflare. The changes include adding configuration files, setting up TypeScript, integrating TailwindCSS for styling, and ensuring server-side rendering. Here are the most important changes:
Cloudflare Example Project:
.gitignoreandREADME.mdfor guidance. (examples/cloudflare/.gitignore,examples/cloudflare/README.md) [1] [2]examples/cloudflare/app/app.css,examples/cloudflare/postcss.config.cjs,examples/cloudflare/tailwind.config.ts) [1] [2] [3]React Router Integration:
examples/cloudflare/app/entry.server.tsx,examples/cloudflare/app/root.tsx) [1] [2]examples/cloudflare/app/routes.ts,examples/cloudflare/app/routes/home.tsx,examples/cloudflare/app/welcome/welcome.tsx) [1] [2] [3]Build and Deployment:
examples/cloudflare/rsbuild.config.ts,examples/cloudflare/package.json) [1] [2]examples/cloudflare/server/app.ts)These changes collectively establish a robust foundation for developing and deploying a React application with modern tools and best practices.